Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Updating email and phone without password #5621

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Allow Updating email and phone without password #5621

merged 3 commits into from
Jun 2, 2023

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Jun 1, 2023 •
edited
Loading

What does this PR do?

  • Fix 500 error when a passwordless user creates an email session
  • Don't rely on isAnonymousUser to check whether to verify password
  • Update the Update Phone API to also set the password

Closes: #4975

Test Plan

Automated tests should pass

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90
Fix 500 error when a passwordless user creates an email session
7dec6c7
@stnguyen90
Don't rely on isAnonymousUser to check whether to verify password
5ef3162 
It's possible for a user to not be anonymous and not have a password.
Using passwordUpdate is a better indicator as to whether the user has
set a password or not.
@stnguyen90
Update the Update Phone API to also set the password
5afc497 
This is to ensure the behavior matches the Update Email endpoint.
@stnguyen90 stnguyen90 changed the base branch from master to 1.4.x June 1, 2023 00:32
@stnguyen90 stnguyen90 marked this pull request as ready for review June 1, 2023 22:10
@stnguyen90 stnguyen90 mentioned this pull request Jun 1, 2023
Closed
2 tasks
@eldadfux eldadfux merged commit 994524b into 1.4.x Jun 2, 2023
5 checks passed
@stnguyen90 stnguyen90 deleted the fix-4975-update-email-phone-without-password branch June 2, 2023 16:22
@stnguyen90 stnguyen90 linked an issue Jun 7, 2023 that may be closed by this pull request
🚀 Feature: Re-hash Password on Phone Update #4990
Closed
2 tasks
@stnguyen90 stnguyen90 mentioned this pull request Jul 22, 2023
Merged
This was referenced Jul 25, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@stnguyen90 stnguyen90 mentioned this pull request Sep 18, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stnguyen90 @eldadfux