Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: more accurate email validation at sign in and sign up #4963

Open
2 tasks done
donni106 opened this issue Jan 6, 2023 · 7 comments
Open
2 tasks done
Labels
product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.

Comments

@donni106
Copy link

donni106 commented Jan 6, 2023

🔖 Feature description

The sign in and sign up forms validate the email address:

image

When passing without the ending, i.e. ".com", the validation is missing and the form is sent to the server, which then validates:

image

The email input could already validate against the full accurate email format.

🎤 Pitch

As the email format will be validates after sending the form anyways and there exists a form input validation in the frontend, it could be extended with the full email format validation including ".com" endings.

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@donni106 donni106 changed the title 🚀 Feature: more accurate email validation at sign in 🚀 Feature: more accurate email validation at sign in and sign up Jan 6, 2023
@stnguyen90 stnguyen90 added product / console Console, UI and UX issues good first issue Good for newcomers and removed good first issue Good for newcomers labels Jan 6, 2023
@stnguyen90
Copy link
Contributor

@TorstenDittmann, do we want to update the client-side validation for this? According to MDN, something@something is valid:

A single properly-formed email address. This doesn't necessarily mean the email address exists, but it is at least formatted correctly. In simple terms, this means username@domain or [email protected].

@shishir-prasad
Copy link

Hi,
I can work on this issue.

@AkashSharma001
Copy link

I would like to work on this.
@stnguyen90

@TGlide
Copy link
Contributor

TGlide commented Jan 10, 2023

@TorstenDittmann, do we want to update the client-side validation for this? According to MDN, something@something is valid:

A single properly-formed email address. This doesn't necessarily mean the email address exists, but it is at least formatted correctly. In simple terms, this means username@domain or [email protected].

IMO, formatting email client side can lead to errors. There are so many possible ways to write an email, that even this regex doesn't 100% work. There are other issues too.

@donni106
Copy link
Author

Anyways I suggest having the same validations in the client and on the server?!

@Nandini99-git
Copy link

It looks like you are sign in for the first time. Follow this step

  1. click to sign-in now
  2. accept the certificate
    and now try to sign up
    I hope this will help.

@TorstenDittmann
Copy link
Contributor

@TorstenDittmann, do we want to update the client-side validation for this? According to MDN, something@something is valid:

A single properly-formed email address. This doesn't necessarily mean the email address exists, but it is at least formatted correctly. In simple terms, this means username@domain or [email protected].

Yeah, let's allow these e-mails. Especially in Windows domain and co its quite common to have these type of e-mails.

@stnguyen90 stnguyen90 added product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services. and removed product / console Console, UI and UX issues labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.
Projects
None yet
Development

No branches or pull requests

7 participants