🐛 Bug Report: LinkedIn Oauth2 Broken

[superseby2]

👟 Reproduction steps

• create an Oauth2Session like so appwrite.account.createOAuth2Session('linkedin',successPath,errorPath)
• Linkedin prompts for credentials
• On submit, Linkedin displays ""Bummer, something went wrong.
  We're having difficulty connecting."

We have opened an issue at LinkedIN here is their reply :

We see that in the URI the request has an encoded state parameter and redirectURI parameter. However the state parameter should be a unique string as recommended by https://www.rfc-editor.org/rfc/rfc6749#section-4.1.1. Please try double encoding the state parameter. Encoding the redirectURI can also cause issues.

Please review our documentation here https://learn.microsoft.com/en-us/linkedin/shared/authentication/authorization-code-flow?tabs=HTTPS

We dived a little bit our side and indeed if we urlencode the state parameter the pb goes away.
from src/Appwrite/Auth/OAuth2/Linkedin.php

  'https://www.linkedin.com/oauth/v2/authorization?' . \http_build_query([
            'response_type' => 'code',
            'client_id' => $this->appID,
            'redirect_uri' => $this->callback,
            'scope' => \implode(' ', $this->getScopes()),
            'state' => urlencode(\json_encode($this->state)),
        ]);

from 'app/controllers/api/account.phpinApp::get('/v1/account/sessions/oauth2/:provider/redirect')` line 363

$state = urldecode($state);

It seems lile LinkedIN urldecode his side and the state being only url-encoded once messes up somehow when decoded. (At least that is my understanding).
It might actually make sense to do this for every OAuth providers as "state" as defined by the RFC should be a String and nothing else.

Could you please have a look ?

👍 Expected behavior

• When the login is successful the redirectURL should be called
• The user should be loggedin

👎 Actual Behavior

• Users see the LinkedIn Error Page
• Users are not logged in into our app

🎲 Appwrite version

Version 0.14.x

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[stnguyen90]

Thanks for raising this! 🙏🏼 We'll look into this as soon as we can!

[SoulPancake]

@stnguyen90 Can I work on this? Seems fairly straightforward as @superseby2 suggested, are there any additional caveats to this?

[stnguyen90]

@SoulPancake there may be some other implications. Best to leave this with the core team.

[stnguyen90]

So I just tested this on the latest version of Appwrite, but I wasn't able to reproduce the problem as the session created fine for me:

@superseby2, are you still experiencing this or may I close this issue?

[gewenyu99]

@stnguyen90 I'm closing due to inactivity. Feel free to reopen if you found this issue, and have reproduction steps.