Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug Report: redirect to the failure url instead of throwing an error in OAuth2 #4753

Closed
2 tasks done
gepd opened this issue Nov 22, 2022 · 2 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.
Milestone

Comments

@gepd
Copy link
Contributor

gepd commented Nov 22, 2022

馃憻 Reproduction steps

  1. Login with any OAuth2 Provider
  2. Block the user in the console
  3. Login with the OAuth2 provider again

馃憤 Expected behavior

I would expect to be redirected to the failure url. I have some doubt about if the failure url should have any extra information as for example, we have USER_BLOCKED, USER_MISSING_ID, GENERAL_SERVER_ERROR and many other errors, and go to the failure url without any other data will be too generic

馃憥 Actual Behavior

Currently if we block a user and this user try to login with any OAuth2 provider, you will get a scarry 401 error.
The current implementation makes imposible to catch this error

I have also noted that the error trace shows a lot of information, and some of them could be sensitive.

image

馃幉 Appwrite version

Version 1.1.x

馃捇 Operating system

Linux

馃П Your Environment

No response

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@gepd gepd added the bug Something isn't working label Nov 22, 2022
@stnguyen90 stnguyen90 changed the title 馃悰 Bug Report: redirect to the failure url instead of throws an error in OAuth2 馃悰 Bug Report: redirect to the failure url instead of throwing an error in OAuth2 Nov 22, 2022
@stnguyen90 stnguyen90 added the product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services. label Nov 22, 2022
@stnguyen90
Copy link
Contributor

@gepd, thanks for raising this issue! 馃檹馃徏 Let me discuss this with the team

@stnguyen90
Copy link
Contributor

Related issue: #2591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.
Projects
None yet
Development

No branches or pull requests

2 participants