Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: OAuth2 implementation does not enforce email retrieval #3680

Open
2 tasks done
ddenev opened this issue Aug 14, 2022 · 3 comments
Open
2 tasks done
Labels
bug Something isn't working product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.

Comments

@ddenev
Copy link

ddenev commented Aug 14, 2022

👟 Reproduction steps

Currently, when the user is presented with the Facebook oauth screen, the user can select 'Edit access" and then switch off the email.
image
image
This means that, after the user disables the email and clicks Continue, a new user will be created in Appwrite but without an email address.

Similar thing is happening with the Yandex OAuth2 adapter - users are created but without email address.

Discord post - https://discord.com/channels/564160730845151244/564175717521424424/1007611652750970900

👍 Expected behavior

Appwrite should extend the OAuth2 adapters to always enforce the retrieval of email address

👎 Actual Behavior

Users are created without an email address

🎲 Appwrite version

Version 0.15.x

💻 Operating system

Windows

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@ddenev ddenev added the bug Something isn't working label Aug 14, 2022
@stnguyen90 stnguyen90 added the product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services. label Aug 14, 2022
@ashutoshpw
Copy link

ashutoshpw commented Sep 9, 2022

I would like to work on this can someone assign to me?

@stnguyen90
Copy link
Contributor

@ddenev, would it be okay to close this issue as a duplicate of #1192? It would be good if you 👍🏼 that issue as well.

@ddenev
Copy link
Author

ddenev commented May 21, 2023

Hi @stnguyen90

thanks for replying! I would not consider this issue as a duplicate to #1192 - these are two different issues.

At the end, it's your decision whether to merge them, just make sure fixing the other also fixed the 2 problems that are stated here - with Facebook and with Yandex.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.
Projects
None yet
Development

No branches or pull requests

3 participants