Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Add event to get token from createMagicURL #3120

Open
2 tasks done
gepd opened this issue Apr 20, 2022 · 3 comments
Open
2 tasks done

馃殌 Feature: Add event to get token from createMagicURL #3120

gepd opened this issue Apr 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@gepd
Copy link
Contributor

gepd commented Apr 20, 2022

馃敄 Feature description

add account.session.magic.create (or similar ) event to be use with appwrite webhooks and functions to get the token when we use createMagicURL, this will allow us to run a function and generate our own email design with a custom domain if we want

馃帳 Pitch

Currently Appwrite have two issues with emails;
the first one, we can't easily customise the design and the second, we can't use a domain per project to send an email.

This feature will complement #3115 and #730 and will give full controll to send email with custom design and use a different domain per project

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@gepd gepd added the feature label Apr 20, 2022
@gepd gepd changed the title 馃殌 Feature: Add event createMagicURL 馃殌 Feature: Add event to get token with createMagicURL Apr 20, 2022
@gepd gepd changed the title 馃殌 Feature: Add event to get token with createMagicURL 馃殌 Feature: Add event to get token from createMagicURL Apr 20, 2022
@Meldiron
Copy link
Contributor

I like it... Sounds like a smooth solution to custom channels for sharing secrets.

One concern I have is what if I only want to send secrets using SMS? How would I disable the email that Appwrite sends by default? 馃

@gepd
Copy link
Contributor Author

gepd commented Apr 20, 2022

Currently I have set wrong data to avoid the error (SMTP disabled)
but would be good to have a better solution like an env var to make the SMTP not mandatory

@gepd
Copy link
Contributor Author

gepd commented Apr 20, 2022

Thinking more about the SMTP, disable it with wrong data is not the best option (or any other way to bypass it), currently we use that data for actions with the super admin too, so If we disable the SMTP and we want to recover the account of the super admin it won't be possible.

a better solution would be to have an env var like _APP_SMTP_SUPER when this is true, SMTP will be used only for actions who required an email from the super admin, the rest of the email should be manually handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants