-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Feature: Add docker (container) health check #2908
Comments
Might be a bit complex as we use the same Dockerfile for all internal containers for easier maintenance. @TorstenDittmann, @lohanidamodar got any ideas what would be the best approach? |
and So @eldadfux I think we should be add it to each of our containers in compose stack |
I'll close this know as it's not a priority. Happy to reopen if someone would like to make a PR and update the compose file. |
Wouldn't it be better to keep it open with a label like |
🔖 Feature description
Adding a
HEALTHCHECK
command to theDockerfile
, for all the appwrite containers.For example, to check every five minutes that a web-server is able to serve the main page within three seconds:
HEALTHCHECK CMD curl --fail http:https://localhost || exit 1
🎤 Pitch
Adding a
HEALTHCHECK
to theDockerfile
would provide the users a better overview of the containers. Docker will execute theHEALTHCHECK
command when the container spins up, and report "starting" until theHEALTHCHECK
succeeds, or fails. If theHEALTHCHECK
passes, the container will report "healthy".Appwrite already provides some health check API endpoints, so I think it would make sense to include those.
Also, this would make it very easy to spot "faulty" behaviour. I think it would also make the development of appwrite a little easier.
Screenshot of portainer with containers that have a healthcheck and containers that don't
👀 Have you spent some time to check if this issue has been raised before?
🏢 Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: