Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Protect endpoints with password #2752

Closed
2 tasks done
Meldiron opened this issue Feb 6, 2022 · 1 comment
Closed
2 tasks done

🚀 Feature: Protect endpoints with password #2752

Meldiron opened this issue Feb 6, 2022 · 1 comment

Comments

@Meldiron
Copy link
Contributor

Meldiron commented Feb 6, 2022

🔖 Feature description

Password is currently only being used when creating a session. We should also use password to protect account-critical update endpoints, for instance, deleting the account.

Before implementing the feature, we should discuss which endpoints exactly should be protected. We can keep 2FA in mind, and be aware that all password-protected endpoints will most likely be also protected by 2FA code in future.

🎤 Pitch

I was writing RFC for 2FA and I noticed we currently don't protect client-SDK endpoints with password properly. We have the functionality in Appwrite Console, but we never added this option to SDKs.

CleanShot 2022-02-06 at 11 22 46@2x

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@eldadfux
Copy link
Member

This implementation would make the API behavior a bit more complex, so this is not something we would want to prioritize at the moment. That said, in console 2.0 we've added many dialogs to prevent destructive action being made by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants