-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug Report: OAuth2 does not add port number to redirect uri #2365
Comments
Hello, Can I be assigned to this issue? |
I have assigned you to this issue, let me know if you need any help. |
I already opened a PR on it but couldn't write the proper tests as I'm a PHP noob. |
Hello, I have the same problem. Is there any solution? |
@skyface753, for now, I recommend exposing Appwrite on the standard ports. If you need other apps on the same server on standard ports, you can out a reverse proxy in front. |
1 similar comment
@skyface753, for now, I recommend exposing Appwrite on the standard ports. If you need other apps on the same server on standard ports, you can out a reverse proxy in front. |
@stnguyen90 When you say exposing appwrite on the standard ports, I'm assuming that means 80/443, which won't work if you're developing locally, no? I see there was some progress made in the PR 2368. |
@kilroyjones, what's wrong with running Appwrite on 80/443 locally? |
Hello, I have the same problem. Is there any solution? |
Is this issue up for grabs? If yes, I would like to work on this @stnguyen90 |
@KaranJagtiani, as part of working on this, can you test how this behaves if there's a reverse proxy in front of appwrite? Many people have configured Appwrite to run on non-standard ports like 8080 and 4443, but expose Appwrite nonstandard ports through a reverse proxy. It's crucial for the redirect to still use the ports from the original request that the reverse proxy receives. |
Can I work on this issue? |
Try to change the appwrite port to the standard one, i think it's 80:80 CMIIW |
@krishnaa192, are you still interested in working on this? |
👟 Reproduction steps
When I started my appwrite server, I set it to run on port 3000 for http and left all other values as their defaults.
I added Google OAuth by following all the required steps:
👍 Expected behavior
I expected the redirect URI to have port 3000
👎 Actual Behavior
I get an error saying:
and I noticed that the redirect_uri didn't have the port 3000 on it.
One of the maintainers helped track down the issue to line 292 in this file
🎲 Appwrite version
Different version (specify in environment)
💻 Operating system
Windows
🧱 Your Environment
I'm using version 0.11.0
👀 Have you spent some time to check if this issue has been raised before?
🏢 Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: