-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define optional dependencies as extras #126
Labels
Comments
✔️ All good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we rely on our installer detecting the presence of certain dependencies and installing the right
opentelemetry-instrumentation-something
package for them, or on users manually installing those dependencies as described on the docs.We could use "package extras", which are optional dependencies that are specified at install time, to improve the experience somewhat. Instead of installing
appsignal
andopentelemetry-instrumentation-django
, users could installappsignal[django]
, which would install both. The installer could also do this. (More than one can be installed -- e.g.appsignal[django,celery]
)This also allows us to specify version bounds for the OpenTelemetry instrumentation package, ensuring that our users aren't upgrading their AppSignal package, but using an old (potentially unsupported or missing features) version of the instrumentations.
requirements.txt
The text was updated successfully, but these errors were encountered: