Complete NIOCore strict concurrency #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: With our earlier big refactors, NIOCore is now currently strict concurrency clean. Let's lock in the win by adopting the relevant Swift settings and fixing up the tests. Modifications: - Adopt our strict concurrency settings in NIOCore and NIOCoreTests - Clean up the tests Result: One step closer to a world without warnings.
ec5b58f
to
2c8d72c
Compare
FranzBusch
approved these changes
Oct 31, 2024
Lukasa
added a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 20, 2024
This reverts commit 37b31b9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With our earlier big refactors, NIOCore is now currently strict concurrency clean. Let's lock in the win by adopting the relevant Swift settings and fixing up the tests.
Modifications:
Result:
One step closer to a world without warnings.