cups_finalize_client_conf checks the DOMAINSOCKET for execution bit

[michaelrsweet]

Version: 2.1-current
CUPS.org User: odyx

Yves-Alexis Perez reported that since 2.x, cups clients don't connect to the correct socket: https://bugs.debian.org/792730.

I've tried to debug this, and my analysis is that since 2.x, lpstat -H reports localhost:631 instead of /var/run/cups/cups.sock , even with the socket file as follows in both 1.7 and 2.0:

srw-rw-rw- 1 root root 0 jui 18 12:36 /var/run/cups/cups.sock

I've traced this to be correctible by changing the access checks in cups_finalize_client_conf, with the attached patch.

Does this make sense?

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

Pretty sure exec/search bit should be set on domain sockets, but read/write is enough for this check.

[michaelrsweet]

"fix_local_domainsocket_access_checking.patch":

Description: In absence of client.conf configuration, the default domain socket
(/var/run/cups/cups.sock) will get checked for read, write and execution bits,
but the latter doesn't make sense
Author: Didier Raboud [email protected]
Origin: vendor
Bug-Debian: https://bugs.debian.org/792730
Last-Update: 2015-07-18
--- a/cups/usersys.c
+++ b/cups/usersys.c
@@ -1017,7 +1017,7 @@
struct stat sockinfo; /* Domain socket information */

 if (!stat(CUPS_DEFAULT_DOMAINSOCKET, &sockinfo) &&

• (sockinfo.st_mode & S_IRWXO) == S_IRWXO)
• (sockinfo.st_mode & (S_IROTH | S_IWOTH) ) == (S_IROTH | S_IWOTH))
  cups_set_server_name(cc, CUPS_DEFAULT_DOMAINSOCKET);
  else
  #endif /* CUPS_DEFAULT_DOMAINSOCKET */