It is impossible to disable SNMP queries for network printers

[michaelrsweet]

Version: 1.7-current
CUPS.org User: mmucha

In cups-1.7.3 it is impossible to disable SNMP lookups for supply levels using "snmp" argument in printer URI as stated in https://www.cups.org/documentation.php/doc-1.7/network.html.
Bug is present in IPP, SOCKET and LPD protocols due to code duplication.
Problem exists because of invalid expression used for parsing argument's value and can be solved by applying attached patch.
I can't verify if problem exists in the git repository because I receive errors when I try to clone it.

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

[michaelrsweet]

"cups-1.7.3-snmp.patch":

diff -rupN cups-1.7.3/backend/ipp.c cups-1.7.3-snmpfix/backend/ipp.c
--- cups-1.7.3/backend/ipp.c 2014-05-22 15:59:21.000000000 +0200
+++ cups-1.7.3-snmpfix/backend/ipp.c 2014-05-30 16:37:43.127973343 +0200
@@ -528,8 +528,8 @@ main(int argc, /* I - Number of comm
*/

      snmp_enabled = !value[0] || !_cups_strcasecmp(value, "on") ||

•                    _cups_strcasecmp(value, "yes") ||
  

•                    _cups_strcasecmp(value, "true");
  

•                    !_cups_strcasecmp(value, "yes") ||
  

•                    !_cups_strcasecmp(value, "true");
  

  }
  else if (!_cups_strcasecmp(name, "version"))
  {
  diff -rupN cups-1.7.3/backend/lpd.c cups-1.7.3-snmpfix/backend/lpd.c
  --- cups-1.7.3/backend/lpd.c 2013-05-29 13:51:34.000000000 +0200
  +++ cups-1.7.3-snmpfix/backend/lpd.c 2014-05-30 16:37:32.317973181 +0200
  @@ -393,8 +393,8 @@ main(int argc, /* I - Number of comm
  */

    snmp_enabled = !value[0] || !_cups_strcasecmp(value, "on") ||
  

•                    _cups_strcasecmp(value, "yes") ||
  

•                    _cups_strcasecmp(value, "true");
  

•                    !_cups_strcasecmp(value, "yes") ||
  

•                    !_cups_strcasecmp(value, "true");
  

  }
  else if (!_cups_strcasecmp(name, "timeout"))
  {
  diff -rupN cups-1.7.3/backend/socket.c cups-1.7.3-snmpfix/backend/socket.c
  --- cups-1.7.3/backend/socket.c 2013-05-29 13:51:34.000000000 +0200
  +++ cups-1.7.3-snmpfix/backend/socket.c 2014-05-30 16:37:56.687973546 +0200
  @@ -250,8 +250,8 @@ main(int argc, /* I - Number of comm
  */

    snmp_enabled = !value[0] || !_cups_strcasecmp(value, "on") ||
  

•                    _cups_strcasecmp(value, "yes") ||
  

•                    _cups_strcasecmp(value, "true");
  

•                    !_cups_strcasecmp(value, "yes") ||
  

•                    !_cups_strcasecmp(value, "true");
  

  }
  else if (!_cups_strcasecmp(name, "contimeout"))
  {