Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge error types in apollo-compiler #825

Open
goto-bus-stop opened this issue Feb 8, 2024 · 0 comments
Open

Merge error types in apollo-compiler #825

goto-bus-stop opened this issue Feb 8, 2024 · 0 comments
Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation

Comments

@goto-bus-stop
Copy link
Member

apollo-compiler has several error enums, which for users ultimately only end up being accessed behind a DiagnosticList or DiagnosticData. We don't really use the different error enums for anything internally either, so it would be simpler to just have everything in one big enum.

This doesn't strictly need to happen at any particular point because it's not exposed, but it would make it easier to add errors in the future because we won't need to think about where to put them or put them in a place where they don't really belong.

@goto-bus-stop goto-bus-stop added the apollo-compiler issues/PRs pertaining to semantic analysis & validation label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation
Projects
None yet
Development

No branches or pull requests

1 participant