Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async timeout callback support to Java binding #34

Open
mbarger99 opened this issue Jun 11, 2018 · 0 comments
Open

Add async timeout callback support to Java binding #34

mbarger99 opened this issue Jun 11, 2018 · 0 comments

Comments

@mbarger99
Copy link
Contributor

Follow-on to #26. We made the updates to support a new async request timeout without breaking backwards compatibility for C++ and Python by providing a default implementation for the new callback method. For Java though, we use an interface to define the callback methods. Java 8 adds support for providing a default impl in an interface, but we need to maintain support for Java 6 and 7 for the MATLAB versions we use. So adding Java support here will break backwards compatibility as it will require all classes that implement GravityRequestor to implement this new method.

We will make this change when we have other pending changes that will also break backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant