Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variants of %n (%+9n) still crash logger #139

Open
kguilbert opened this issue Jan 31, 2020 · 3 comments
Open

Variants of %n (%+9n) still crash logger #139

kguilbert opened this issue Jan 31, 2020 · 3 comments

Comments

@kguilbert
Copy link
Contributor

The fix for Issue #137 fixed crashes due to %n but other variants still result in a crash. For example, %+9n causes a crash.

@mbarger99
Copy link
Contributor

Tests pass on Ubuntu 16.04, but fail on Ubuntu 18.04.

@mbarger99 mbarger99 reopened this Feb 3, 2020
@mbarger99 mbarger99 mentioned this issue Feb 3, 2020
@mbarger99
Copy link
Contributor

Other arbitrary sequences can also trigger this that are not covered by the fix here, e.g. %In (that's a capital i, not a lowercase L). Not sure how to address this case (and other as yet undiscovered cases like this) such that it gets around the issue in all supported languages.

@mbarger99 mbarger99 reopened this Feb 4, 2020
@mbarger99
Copy link
Contributor

Testing on Ubuntu 16.04 shows that I (uppercase i), q, Z and ' (single quote) are the printable characters that are not already covered. This is likely system dependent, but going overboard here would be better than an unexpected crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants