Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8313] Fix the issue that Remoting producer cannot end transactions in time #8319

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #8313] Fix the issue that Remoting producer cannot end transactions in time #8319

wants to merge 2 commits into from

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented Jun 21, 2024

Which Issue(s) This PR Fixes

Fixes #8313

Brief Description

  1. Add new method addTransactionData(...) to interface MessagingProcessor
  2. After successfully sending a transaction message, add data to TransationDataManager by calling MessagingProcessor.addTransactionData
  3. Refactor TransactionService: remove never used parameter 'Message' in TransactionService#addTransactionDataByBrokerAddr and TransactionService#addTransactionDataByBrokerName

How Did You Test This Change?

image image

After this change, committed messages can be consumed immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Transaction is committed only after at least once checkTransactionState, which causes message delay
1 participant
@redlsz