Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP 176: Refactor Doc Bot #15797

Closed
4 tasks
Anonymitaet opened this issue May 26, 2022 · 5 comments
Closed
4 tasks

PIP 176: Refactor Doc Bot #15797

Anonymitaet opened this issue May 26, 2022 · 5 comments
Assignees
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. Stale

Comments

@Anonymitaet
Copy link
Member

Anonymitaet commented May 26, 2022

PIP

PIP 176: Refactor Doc Bot to Improve Efficiency of Managing Doc

Issues (new)

  • P0: doc bot check is pending or waiting and documentation label check is changed to label check after it is set to required.

This blocks many PRs, eg. #16298, #16023

This might be caused by GitHub Action limitations https://stackoverflow.com/questions/52200096/github-pull-request-waiting-for-status-to-be-reported

Can you please take a look at it at your earliest convenience? Thank you!

  • P1: when the PR description is empty and the PR author selects labels from Labels, the doc bot should work normally.

  • P2: configure the doc bot to other branches except for master
    - [x] 2.10. Obsever the results and set for other branches if it works well
    - [ ] 2.9
    - [ ] 2.8
    - [ ] 2.7

Issues can't be resolved

Issues (old)

When fixing #15732, @maxsxu found that the doc Bot was implemented by modifying dist rather than src, which makes it hard to maintain and scale.

Consequently, he suggests refactoring the doc Bot along with resolving the following issues in Bot:

Scenario 1

Issue

This PR was marked with doc-related labels and then removed. No doc-related label is marked for this PR.

Expected behavior

In this case, this PR should be labeled w/ doc-label-missing.

image

Scenario 2

Issue

Doc Bot only works for master change.

Expected behavior

Doc Bot should work for all branches and label all PRs.

image

Scenario 3

Issue

Bot labels this PR with several doc labels.

Expected behavior

Bot should label a PR with only a doc label.

image

Improvements

Set documentation label check as one of the GitHub checks.

References

Pulsar Bot

@maxsxu
Copy link
Contributor

maxsxu commented May 26, 2022

Thanks @Anonymitaet brings this out.

More context from the previous maintainer:

Current doc-label-check inspired from https://github.com/harupy/auto-labeling. During the doc bot development, just been modifying the compiled dist/index.js to quickly satisfy requirements.

So from all perspectives, refactoring is necessary. I'll be working on this to make the doc Bot more maintainable and scalable.

@Anonymitaet
Copy link
Member Author

@maxsxu I've added more improvements as we discussed just now

@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. workflow labels May 30, 2022
@Anonymitaet Anonymitaet changed the title Refactor doc Bot PIP 176: Refactor Doc Bot Jun 10, 2022
@maxsxu
Copy link
Contributor

maxsxu commented Jun 11, 2022

The new documentation bot has been implemented at apache/pulsar-test-infra#43

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

The issue had no activity for 30 days, mark with Stale label.

@tisonkun
Copy link
Member

tisonkun commented Dec 6, 2022

Closed as done.

@tisonkun tisonkun closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. Stale
Projects
None yet
Development

No branches or pull requests

3 participants