-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIP-152] Support subscription level dispatch rate limiter setting. #15094
Labels
Comments
Jason918
changed the title
[PIP] Support subscription level dispatch rate limiter setting.
[PIP 152] Support subscription level dispatch rate limiter setting.
Apr 9, 2022
Jason918
changed the title
[PIP 152] Support subscription level dispatch rate limiter setting.
[PIP-152] Support subscription level dispatch rate limiter setting.
Apr 9, 2022
2 tasks
The issue had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
Currently, for message dispatch rate limiter in a subscription , we have 3 level setting :
dispatchThrottlingRatePerSubscriptionInMsg
anddispatchThrottlingRatePerSubscriptionInByte
in broker.conforg.apache.pulsar.client.admin.Namespaces#setSubscriptionDispatchRate
org.apache.pulsar.client.admin.TopicPolicies#setSubscriptionDispatchRate
As we all know, in the pub-sub messaging model, different subscriber of the same topic process the messages for various purpose, and they may have different requirement of message dispatch rate limiter. Here are some use case in my organization:
Goal
Support subscription level dispatch rate limiter setting.
API Changes
Implementation
The rate limiter itself is already implemented with each subscription. We only need to update the rate limiter settings if subscription level config is set.
I propose to just add a new field in
org.apache.pulsar.common.policies.data.TopicPolicies
to store the data.And subscription level rate limiter setting has higher priority than topic level. We need to calculate the applied value when we create the subscription or any level config is changed.
Reject Alternatives
None yet.
The text was updated successfully, but these errors were encountered: