drivers/pipe: fix blocking file_pipe #9130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the fix introduced by 4d6a866, it's necessary to set one end of the file_pipe as non-blocking temporarily while opening the other end to avoid it blocking unexpectedily.
This was referenced Apr 27, 2023
xiaoxiang781216
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #9129
Similar to the fix introduced by #8985, it's necessary to set one end of the
file_pipeas non-blocking temporarily while opening the other end to avoid it blocking unexpectedly.Impact
Fix #9129
Testing
Internal CI,
pipeapp and SIM, with:and,