esp32/wifi: Fix Wi-Fi driver parameter settings #8963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes apache#7857 and apache#7193 by saving Wi-Fi parameters and set them at once, avoiding unknown behaviors of the Wi-Fi driver. This commit also enables setting the auth of the STA/softAP modes while connecting to/providing the wireless network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #7857 and #7193 by saving Wi-Fi parameters and setting them at once, avoiding unknown behaviors of the Wi-Fi driver, like setting auth mode without a valid password.
Also, it enables setting the auth of the STA/softAP modes while connecting to/providing the wireless network.
Finally, it notifies the networking layer about the current state of the STA interface.
Impact
Fix known bugs of the Wi-Fi driver on ESP32 (C3 is not affected because of its driver implementation) and improve security as it sets the minimum auth method to connect to an AP.
Testing
Internal CI testing that covers erroneous behavior prior to this MR.