Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/tcp: fix build break if enable NET_TCP_NO_STACK #7483

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

anchao
Copy link
Contributor

@anchao anchao commented Oct 31, 2022

Summary

net/tcp: fix build break if enable NET_TCP_NO_STACK

devif/ipv6_input.c: In function 'ipv6_input':
devif/ipv6_input.c:59:33: error: 'TCPIPv6BUF' undeclared (first use in this function); did you mean 'IPv6BUF'?
   59 | #define PAYLOAD ((FAR uint8_t *)TCPIPv6BUF)
      |                                 ^~~~~~~~~~
devif/ipv6_input.c:302:14: note: in expansion of macro 'PAYLOAD'
  302 |   payload  = PAYLOAD;     /* Assume payload starts right after IPv6 header */
      |

Signed-off-by: chao an [email protected]

Impact

#7481

Testing

enable config:

CONFIG_NET_TCP=y
CONFIG_NET_IPv6=y
CONFIG_NET_TCP_NO_STACK=y

devif/ipv6_input.c: In function 'ipv6_input':
devif/ipv6_input.c:59:33: error: 'TCPIPv6BUF' undeclared (first use in this function); did you mean 'IPv6BUF'?
   59 | #define PAYLOAD ((FAR uint8_t *)TCPIPv6BUF)
      |                                 ^~~~~~~~~~
devif/ipv6_input.c:302:14: note: in expansion of macro 'PAYLOAD'
  302 |   payload  = PAYLOAD;     /* Assume payload starts right after IPv6 header */
      |

Signed-off-by: chao an <[email protected]>
@xiaoxiang781216 xiaoxiang781216 linked an issue Oct 31, 2022 that may be closed by this pull request
@xiaoxiang781216
Copy link
Contributor

@SPRESENSE please try this patch.

@SPRESENSE
Copy link
Contributor

I have confirmed that the build break has been fixed.

@xiaoxiang781216 xiaoxiang781216 merged commit b353d84 into apache:master Oct 31, 2022
@jerpelea jerpelea added this to To-Add in Release Notes - 12.0.0 Dec 29, 2022
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 12.0.0 Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Build: error by "net: move IPv4/6BUF define to common header"
4 participants