Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stm32h7 kconfig #7017

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Stm32h7 kconfig #7017

merged 2 commits into from
Sep 6, 2022

Conversation

slorquet
Copy link
Contributor

@slorquet slorquet commented Sep 6, 2022

Summary

  • stm32h7 Kconfig menu imbrication was broken, preventing spi peripheral selection
  • stm32h7 spi does not need to depend on EXPERIMENTAL

Impact

  • none

Testing

  • tested in my own working copy, I can now select SPI peripherals, it was impossible to do before that fix.

hartmannathan
hartmannathan approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@hartmannathan hartmannathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@hartmannathan hartmannathan merged commit 179d64d into apache:master Sep 6, 2022
@slorquet slorquet deleted the stm32h7-kconfig branch September 7, 2022 07:57
@slorquet
Copy link
Contributor Author

slorquet commented Sep 7, 2022

Thanks!

@hartmannathan
Copy link
Contributor

Should issue #6973 be closed now or is there anything remaining to do for that issue?

@xiaoxiang781216 xiaoxiang781216 linked an issue Sep 8, 2022 that may be closed by this pull request
STM32H7: SPI is not experimental anymore #6973
Closed
@xiaoxiang781216
Copy link
Contributor

Closed.

@jerpelea jerpelea added this to To-Add in Release Notes - 12.0.0 Dec 29, 2022
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 12.0.0 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@hartmannathan hartmannathan hartmannathan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release Notes - 12.0.0
Added
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STM32H7: SPI is not experimental anymore
3 participants
@slorquet @hartmannathan @xiaoxiang781216