Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses Issue #540, check for missing space before closing comment … #543

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Addresses Issue #540, check for missing space before closing comment … #543

merged 2 commits into from
Mar 11, 2020

Conversation

johannes-nivus
Copy link
Contributor

…was faulty

@johannes-nivus
Copy link
Contributor Author

johannes-nivus commented Mar 11, 2020 •
edited
Loading

Haha this is funny...
Now nxstyle again fails at nxstyle. That's why you shouldn't do something in a hurry.

@patacongo patacongo merged commit 45196ca into apache:master Mar 11, 2020
@patacongo patacongo mentioned this pull request Mar 12, 2020
Closed
@xiaoxiang781216 xiaoxiang781216 linked an issue Mar 13, 2020 that may be closed by this pull request
possible nxstyle false alarm: "Missing space before closing C comment" #540
Closed
@johannes-nivus johannes-nivus mentioned this pull request Mar 13, 2020
Merged
aenrbes pushed a commit to aenrbes/nuttx-on-litex-vexriscv that referenced this pull request Mar 20, 2020
@johannes-nivus
tools/nxstyle.c: Check for missing space before closing comment faulty (
f5ecd65 
apache#543)

*Addresses Issue apache#540, check for missing space before closing comment was faulty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

possible nxstyle false alarm: "Missing space before closing C comment"
2 participants
@johannes-nivus @patacongo