CXD56: move isx012 driver to board specific drivers #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patacongo
reviewed
Mar 6, 2020
| # ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| # POSSIBILITY OF SUCH DAMAGE. | ||
| # | ||
| ############################################################################ |
There was a problem hiding this comment.
I know that you are really only moving a file, but the requirement is that all new files must have Apache 2.0 headers or they cannot come into the repostiory. Please replace this header with one like that in boards/z80/ez80/z20x/src/Makefile -- Note that there is no copyright or author information in the header.
There was a problem hiding this comment.
The same applies to ixx012.c which Github in all of its wisdom will not let me see. Good example for C at sched/sched/sched_getcpu.c
There was a problem hiding this comment.
I am seeing this error in the automated build runs:
====================================================================================
Configuration/Tool: spresense/audio,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Copy files
Select CONFIG_HOST_LINUX=y
Refreshing...
Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Refreshing...
Building NuttX...
------------------------------------------------------------------------------------
platform/camera/Make.defs:1: *** missing separator. Stop.
platform/camera/Make.defs:1: *** missing separator. Stop.
make: *** [drivers/libdrivers.a] Error 2
make: *** Waiting for unfinished jobs....
make: *** wait: No child processes. Stop.
##[error]Process completed with exit code 2.
Reference: https://github.com/apache/incubator-nuttx/runs/491609128
patacongo
requested changes
Mar 6, 2020
This sensor driver needs rework to match the needed layout for standar NuttX driver. In the meantime it is moved to board specific sensors to fix the violation. Signed-off-by: Alin Jerpelea <[email protected]>
The SPECIFIC_DRIVERS configuration was removed from the drivers Kconfig and the build will ignore the specific drivers. This patch enables the config locally for the CXD56 board Signed-off-by: Alin Jerpelea <[email protected]>
patacongo
approved these changes
Mar 6, 2020
cwespressif
pushed a commit
to cwespressif/incubator-nuttx
that referenced
this pull request
Apr 3, 2024
…rebase-2402 [T3PW] [mainline rebase] rebase Nuttx mainline code w2402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workaround for issue 438
#438