Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitations in IPv4 Packet Re-assembly #2328

Open
patacongo opened this issue Nov 17, 2020 · 0 comments
Open

Limitations in IPv4 Packet Re-assembly #2328

patacongo opened this issue Nov 17, 2020 · 0 comments
Labels
Area: Networking Effects networking subsystem State: Missing logic Implementation is Incomplete Type: Bug Something isn't working

Comments

@patacongo
Copy link
Contributor

IPv4 packet re-assembly is implemented in net/devif/ipv4_input.c. The current implementation, however, has too many limitations to be useful:

  1. IPv4 reassembly is untested.
  2. Currently can only work with Ethernet due to the use of Ethernet packet size in the definition of IPv4_REASS_BUFSIZE.
  3. Since there is only a single reassembly buffer, IPv4 reassembly cannot be used in a context where there may be multiple, concurrent re-assembly packets.
  4. The IPv4 header is variable-length depending up on the options in the header. The logic here assumes that the size of the IPv4 header is a constant (this is a bug and not a limitation).
@patacongo patacongo added Type: Bug Something isn't working State: Missing logic Implementation is Incomplete Area: Networking Effects networking subsystem labels Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking Effects networking subsystem State: Missing logic Implementation is Incomplete Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant