CI: Fix check patch to handle renames / deletes #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btashton
force-pushed
the
checkpatch
branch
2 times, most recently
from
a9a72db
to
98e820f
Compare
Signed-off-by: Brennan Ashton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously
checkpatch.shwas usinggit showinstead ofgit diff. The issue with this is we get a list of all the changes from all the commits, this breaks the CI check because it will look for those files in the final result of the patch (which might include a file that got renamed and then edited). We only want to look a the final changes which is what we get fromdiff.We also simplify the computing of the commit range.
Impact
Style checks should be more robust now.
Testing
Local testing and this should be validated by the CI run.