Correct ROMFS hardlink handling #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ef29d3
to
b2d0182
Compare
This PR corrects an error in the ROMFS file system. The error occurred after following a hard link (depending on how the ROMFS image is organized). The error occurred because some of the information buffered before following the links was stale and, hence, out of sync after following the hard link. This would cause random errors when paths containing hardlinks were used with ROMFS. This PR resolves Issue apache#1543. Please compare the following output with the output in Issue apache#1543 to see how the problem was resolved: NuttShell (NSH) NuttX-9.1.0 nsh> mount /etc type romfs /proc type procfs /tmp type vfat nsh> ls -Rl /etc /etc: dr-xr-xr-x 0 . dr-xr-xr-x 0 .. -r-xr-xr-x 20 group dr-xr-xr-x 0 init.d/ -r-xr-xr-x 35 passwd /etc/init.d: dr-xr-xr-x 0 . dr-xr-xr-x 0 .. -r-xr-xr-x 71 rcS nsh> ls -l /etc/init.d /etc/init.d: dr-xr-xr-x 0 . dr-xr-xr-x 0 .. -r-xr-xr-x 71 rcS nsh> ls -l /etc/init.d/. /etc/init.d/.: dr-xr-xr-x 0 . dr-xr-xr-x 0 .. -r-xr-xr-x 71 rcS nsh> ls -l /etc/init.d/.. /etc/init.d/..: dr-xr-xr-x 0 . dr-xr-xr-x 0 .. -r-xr-xr-x 20 group dr-xr-xr-x 0 init.d/ -r-xr-xr-x 35 passwd nsh> ls -l /etc/init.d/../. /etc/init.d/../.: dr-xr-xr-x 0 . dr-xr-xr-x 0 .. -r-xr-xr-x 20 group dr-xr-xr-x 0 init.d/ -r-xr-xr-x 35 passwd nsh>
|
I would be happy to merge this, but I would like consensus: @xiaoxiang781216 OK by you? |
|
@davids5 sure, go ahead. |
|
This is a simply bug fix. It is not controversial. The code was wrong before. It is correct now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR corrects an error in the ROMFS file system. The error may occur after following a hard link (depending upon how the ROMFS image is organized). The error occurred because some of the information buffered before following the links was stale and, hence, out of sync after following the hard link. This would cause random errors when paths containing hardlinks were used with ROMFS.
This PR resolves Issue #1543. Please compare the following output with the output in Issue #1543 to see how the problem was resolved:
Impact
Effects only ROMFS. Should result in reliable performance if hard links are used in paths.
Testing
Testing was performed using the ROMFS file system that is mounted with the sim:nsh configuration.