-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nxstyle should not complain on _Exit #1235
Comments
Maybe nxstyle could be extended to recognize some special comment that instructs to ignore a line (or at least a given rule for that line) |
This has been discussed and I, for one, have been very opposed to corrupting good, clean C files with meta-data for nxstyle. People have talked about a lot of things and we have done the best we can to squash that approach. It is an unbounded, open-ended can or worms. |
for this specific case (_Exit), as it's a part of the standards, it's more appropriate to make nxstyle itself know, IMO. |
There already is a white list in nxstyle.c, we can just add diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index 78351334bf..38b89f98df 100644
--- a/tools/nxstyle.c
+++ b/tools/nxstyle.c
@@ -192,6 +192,7 @@ static const char *g_white_prefix[] =
"ub8", /* Ref: include/fixedmath.h */
"ub16", /* Ref: include/fixedmath.h */
"ub32", /* Ref: include/fixedmath.h */
+ "_Exit", /* Ref: include/stdlib.h */
NULL
}; That actually is just a prefix list but we can do the same for full identifiers. |
e.g.
The text was updated successfully, but these errors were encountered: