boards/stm32: Fix ds1307 and move it to stm32/common #12166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ds1307 doesn't need to call i2c_register() because it is done inside stm32_bringup.c Signed-off-by: Alan C. Assis <[email protected]>
The DS1307 was used as board specific, but it is better move it to stm32/common to be easily used by other boards as well. Signed-off-by: Alan C. Assis <[email protected]>
xiaoxiang781216
approved these changes
Apr 17, 2024
xiaoxiang781216
approved these changes
Apr 17, 2024
jerpelea
approved these changes
Apr 17, 2024
|
@acassis I think it is necessary to add the changes also cmake as well |
You are right! I'll fix it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix ds1307 and move it to stm32/common
Impact
Other boards will be able to use it.
Testing
Only compilation