-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in function headers style #12133
Comments
Yes, I always point out the minor point during review. Maybe it's better to add the check into nxstyle. |
Agree! Better to include it in the checkpatch! |
Is it possible to also add rules in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our coding style guide shows function header like this:
The end of the header is preceded by a new line:
but there are many places in the code where this new line is not added, e.g.:
And from the doc https://nuttx.apache.org/docs/latest/contributing/coding_style.html#function-headers:
Should we correct these places to match the coding standard and pay more attention when reviewing code ?
I know it's a trivial problem, but for some reason it really irritates me when I don't see this additional empty line :)
The text was updated successfully, but these errors were encountered: