build error with kernel mode

[gneworld]

Have a build error after enabling CONFIG_BUILD_KERNEL and CONFIG_ARCH_VMA_MAPPING in sabre-6quad:knsh, as shown below

nuttx$ make -j12
Create version.h
LN: platform/board to /home/official/apps/platform/dummy
Register: hello
Register: init
Register: sh
Register: getprime

CC: clock/clock_settime.c In file included from /home/official/nuttx/include/nuttx/addrenv.h:39,
from addrenv/addrenv.c:30:
/home/official/nuttx/include/arch/arch.h:141:18: error: 'ARCH_SHM_MAXPAGES' undeclared here (not in a function)
141 | uintptr_t *shm[ARCH_SHM_NSECTS];
^~~~~~~~~~~~~~~
Makefile:61: recipe for target 'addrenv.o' failed
make[1]: *** [addrenv.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from /home/official/nuttx/include/nuttx/arch.h:82,
from clock/clock_initialize.c:37

This issue can be fixed by moving the related code in arch.h into addrenv.h, however, is there a better solution for this issue? thanks much

[acassis]

@gneworld please confirm you CONFIG_ARCH_VMA_MAPPING defined in your .config

[gneworld]

@gneworld please confirm you CONFIG_ARCH_VMA_MAPPING defined in your .config

@acassis
Yes, I have confirmed that CONFIG_ARCH_VMA_MAPPING has already been defined in the .config.

[acassis]

@masayuki2009 since you work a lot with sabre-6quad board, could you please take a look?

[gneworld]

just change ARCH_PG2SECT(ARCH_SHM_MAXPAGES)
to ARCH_PG2SECT((CONFIG_ARCH_SHM_NPAGES * CONFIG_ARCH_SHM_MAXREGIONS))
could fix this issue

[acassis]

@gneworld should it be modified into mainline?