Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: raspberrypi-pico: Fix nshsram build error #12025

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

masayuki2009
Copy link
Contributor

Summary

Impact

  • None

Testing

  • Tested with raspberrypi-pico.
  • NOTE: the ci should be fixed later.

Summary:
- This commit fixes apache#11956.
- The issue was introduced by apache#6118.

Impact:
- None

Testing:
- Tested with raspberrypi-pico.
- NOTE: the ci should be fixed later.

Signed-off-by: Masayuki Ishikawa <[email protected]>
@masayuki2009
Copy link
Contributor Author

Hmm what's happening on the macOS runner?

Configuration/Tool: stm32f4discovery/nsh,CONFIG_ARM_TOOLCHAIN_GNU_EABI
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
make: *** [olddefconfig] Error 1
  Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
make: *** [olddefconfig] Error 1
  Building NuttX...
make[1]: *** No rule to make target `context'.
make: *** [libs/libm/.context] Error 2
make: Target `all' not remade because of errors.
/Users/runner/work/nuttx/nuttx/sources/nuttx/tools/testbuild.sh: line 370: /Users/runner/work/nuttx/nuttx/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
  Normalize stm32f4discovery/nsh
make: *** [olddefconfig] Error 1
make: *** [savedefconfig] Error 1
make: *** [olddefconfig] Error 1

@acassis
Copy link
Contributor

acassis commented Mar 31, 2024

@masayuki2009 MacOS CI is very fragile, so let me restart the CI and see if it helps

@xiaoxiang781216 xiaoxiang781216 merged commit 8f22e9c into apache:master Mar 31, 2024
23 of 26 checks passed
masayuki2009 added a commit to masayuki2009/incubator-nuttx that referenced this pull request Apr 1, 2024
Summary:
- This commit applies the fix in apache#12025

Impact:
- None

Testing:
- Build only

Signed-off-by: Masayuki Ishikawa <[email protected]>
xiaoxiang781216 pushed a commit that referenced this pull request Apr 1, 2024
Summary:
- This commit applies the fix in #12025

Impact:
- None

Testing:
- Build only

Signed-off-by: Masayuki Ishikawa <[email protected]>
@masayuki2009 masayuki2009 deleted the fix-raspberrypi-pico branch April 4, 2024 07:36
jerpelea pushed a commit to jerpelea/nuttx that referenced this pull request Apr 5, 2024
Summary:
- This commit applies the fix in apache#12025

Impact:
- None

Testing:
- Build only

Signed-off-by: Masayuki Ishikawa <[email protected]>
xiaoxiang781216 pushed a commit that referenced this pull request Apr 6, 2024
Summary:
- This commit applies the fix in #12025

Impact:
- None

Testing:
- Build only

Signed-off-by: Masayuki Ishikawa <[email protected]>
@jerpelea jerpelea added this to To-Add in Release Notes - 12.5.1 Apr 8, 2024
@jerpelea jerpelea moved this from To-Add to Not Applicable in Release Notes - 12.5.1 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
4 participants