Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add a toolchaine file for CMake in exported archive. #10398

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

leducp
Copy link
Contributor

@leducp leducp commented Aug 25, 2023

Summary

Add a CMake toolchain in the exported archive so that application can use it directly.
close #10402

Impact

Testing

@leducp
Copy link
Contributor Author

leducp commented Aug 25, 2023

Should I create then link an issue to this PR?

@leducp leducp changed the title Add a toolchaine file for CMake in exported archive. RFC: Add a toolchaine file for CMake in exported archive. Aug 25, 2023
@xiaoxiang781216
Copy link
Contributor

Should I create then link an issue to this PR?

Yes, it's better to have an issue.

@leducp leducp marked this pull request as ready for review August 25, 2023 09:51
@xiaoxiang781216
Copy link
Contributor

@Siviuze could you fix the warning reported by ci:
https://github.com/apache/nuttx/actions/runs/5973272863/job/16205220666?pr=10398

@leducp
Copy link
Contributor Author

leducp commented Aug 28, 2023

@Siviuze could you fix the warning reported by ci: https://github.com/apache/nuttx/actions/runs/5973272863/job/16205220666?pr=10398

Fixed :)

@leducp leducp changed the title RFC: Add a toolchaine file for CMake in exported archive. Draft: RFC: Add a toolchaine file for CMake in exported archive. Aug 28, 2023
@leducp leducp changed the title Draft: RFC: Add a toolchaine file for CMake in exported archive. RFC: Add a toolchaine file for CMake in exported archive. Aug 28, 2023
tools/toolchainfile.cmake Outdated Show resolved Hide resolved
@leducp leducp force-pushed the cmake_toolchain_file branch 2 times, most recently from 4ec05f3 to 3667977 Compare August 28, 2023 11:54
@leducp
Copy link
Contributor Author

leducp commented Aug 28, 2023

@Siviuze could you fix the warning reported by ci: https://github.com/apache/nuttx/actions/runs/5973272863/job/16205220666?pr=10398

Fixed :)

Fixed again : I messed up with my previous try.

tools/mkexport.sh Outdated Show resolved Hide resolved
…a generic CMake toolchain file

Add a toolchain file for CMake that can be used in the exported NuttX archive.
@xiaoxiang781216 xiaoxiang781216 merged commit 5dbffd0 into apache:master Aug 29, 2023
26 checks passed
@jerpelea jerpelea added this to To-Add in Release Notes - 12.3.0 Sep 26, 2023
@leducp leducp deleted the cmake_toolchain_file branch October 1, 2023 12:17
@jerpelea jerpelea moved this from To-Add to done in Release Notes - 12.3.0 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
4 participants