Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

test_operator_gpu.test_bilinear_sampler_with_type has fixed seed that can mask flakiness #11726

Open
szha opened this issue Jul 13, 2018 · 2 comments

Comments

@szha
Copy link
Member

szha commented Jul 13, 2018

The unit test in title have been using fixed seed to mask flakiness. Suggested action:

  1. Evaluate whether the test is flaky without fixed seed. If not, remove seed. Else move to 2
  2. If test is flaky, determine whether it's an actual uncaught edge case. If so, fix the operator. Else move to 3
  3. If numerical instability is inevitable, adjust tolerance level appropriately.
@szha szha added this to To Do in Tests Improvement via automation Jul 13, 2018
@apeforest
Copy link
Contributor

Thannks for filing this issue. We will investigate this Flaky test

@nswamy
Copy link
Member

nswamy commented Aug 4, 2018

ran the test 100K on CPU, no issue on CPU. Running on GPU fails after 5-10 iterations. Identifying which dType causes the test to fail in DEBUG mode.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

3 participants