SOLR-15154: Let Http2SolrClient pass Basic Auth credentials to all requests #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quests Credentials can now be set explicitly at the client level, or can be read from System properties like in the previous version of the client when using PreemptiveBasicAuthClientBuilderFactory. Other implementations of HttpClientBuilderFactory can now also be used.
anshumg
reviewed
Mar 3, 2021
| private void httpClientBuilderSetup(Http2SolrClient client) { | ||
| String factoryClassName = System.getProperty(HttpClientUtil.SYS_PROP_HTTP_CLIENT_BUILDER_FACTORY); | ||
| if (factoryClassName != null) { | ||
| log.debug ("Using Builder Factory: {}", factoryClassName); |
There was a problem hiding this comment.
Using HTTP Client Builder Factory?
| public Builder withBasicAuthCredentials(String user, String pass) { | ||
| if (user != null || pass != null) { | ||
| if (user == null || pass == null) { | ||
| throw new IllegalStateException("Invalid Authentication credentials. Either both or none must be provided"); |
There was a problem hiding this comment.
both -> both user(name) and password ?
| unIgnoreException("Error from server"); | ||
| assertTrue(DebugServlet.headers.size() > 0); | ||
| String authorizationHeader = DebugServlet.headers.get("authorization"); | ||
| assertNotNull("Expecting authorization header but got: " + DebugServlet.headers, authorizationHeader); |
There was a problem hiding this comment.
Does it make sense to reframe the test failure message as No authorization information in the header found. Header :
Feel free to ignore it, but as you were printing the entire header, I thought specifying that made it more obvious.
tflobbe
added a commit
to tflobbe/lucene-solr-1
that referenced
this pull request
Mar 5, 2021
…quests (apache#2445) Credentials can now be set explicitly at the client level, or can be read from System properties like in the previous version of the client when using PreemptiveBasicAuthClientBuilderFactory. Other implementations of HttpClientBuilderFactory can now also be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credentials can now be set explicitly at the client level, or can be read from System properties like in the previous version of the client when using
PreemptiveBasicAuthClientBuilderFactory. Other implementations ofHttpClientBuilderFactorycan now also be used.This test also adds a small refactor to
PreemptiveBasicAuthClientBuilderFactoryfor better testing.