[GLUTEN-6101][VL] Enable map_from_array function #6102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
WangGuangxin
force-pushed
the
feat_map_from_array
branch
from
39d3de1
to
8a63ee0
Compare
|
Run Gluten Clickhouse CI |
rui-mo
reviewed
Jun 20, 2024
|
Run Gluten Clickhouse CI |
PHILO-HE
reviewed
Jun 25, 2024
| val mapKeyDedupPolicy = SQLConf.get.getConf(SQLConf.MAP_KEY_DEDUP_POLICY) | ||
| val newSubstraitExprName = | ||
| if (mapKeyDedupPolicy == SQLConf.MapKeyDedupPolicy.EXCEPTION.toString) { | ||
| "map_from_arrays_exception_on_duplicates" |
There was a problem hiding this comment.
Is this function name really used?
There was a problem hiding this comment.
yes, it's related to facebookincubator/velox#10280.
But I think it's more reasonable to check the mapKeyDedupPolicy config in velox instead of register two functions. WDYT @PHILO-HE @rui-mo @jinchengchenghh
There was a problem hiding this comment.
Using a config looks better to me. But it requires some extra code change for that presto function. You can check with Meta guys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable map_from_array function
(Fixes: #6101)
How was this patch tested?
UT