-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Enhance jni signature with a more readable way #5890
Labels
enhancement
New feature or request
Comments
A good example is splitResultConstructor, which seems not matched with java definition. |
zhli1142015
changed the title
The optimization for the method signature
[Core] The optimization for the method signature
May 28, 2024
zhli1142015
changed the title
[Core] The optimization for the method signature
[Core] Optimize JNI method signatures
May 28, 2024
zhli1142015
changed the title
[Core] Optimize JNI method signatures
[Core] Enhance jni signature with a more readable way
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Current the method signature is set with current plain text, which is not so good to maintain and read like "(J[J[II[B)V" and confusing for onboarding and in maintenance.
The signature is generated by the parameter type list and the return value type.
A better way is like below :
typeid
in cpp, to signaturegetMethodIdOrError
from current signature to the parameter list and return type and call the method abovegetMethodIdOrError
.cc: @zhouyuan , @zhztheplayer , @FelixYBW
The text was updated successfully, but these errors were encountered: