Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix common checkstyle error #1591

Merged
merged 18 commits into from
Feb 29, 2024
Merged

fix common checkstyle error #1591

merged 18 commits into from
Feb 29, 2024

Conversation

a-little-fool
Copy link
Contributor

deal checkstyle error

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 28, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Feb 28, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 29, 2024
@tomsun28 tomsun28 changed the title Common checkstyle error fix common checkstyle error Feb 29, 2024
@tomsun28 tomsun28 added this to the 1.5.1 milestone Feb 29, 2024
@tomsun28 tomsun28 linked an issue Feb 29, 2024 that may be closed by this pull request
@tomsun28 tomsun28 self-requested a review February 29, 2024 02:13
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 29, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 29, 2024
@tomsun28 tomsun28 merged commit 717158a into master Feb 29, 2024
2 checks passed
@tomsun28 tomsun28 deleted the common-checkstyle-error branch February 29, 2024 02:47
@tomsun28 tomsun28 linked an issue Feb 29, 2024 that may be closed by this pull request
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: cuipiheqiuqiu <[email protected]>
Co-authored-by: Logic <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: cuipiheqiuqiu <[email protected]>
Co-authored-by: Logic <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: cuipiheqiuqiu <[email protected]>
Co-authored-by: Logic <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: cuipiheqiuqiu <[email protected]>
Co-authored-by: Logic <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: cuipiheqiuqiu <[email protected]>
Co-authored-by: Logic <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: cuipiheqiuqiu <[email protected]>
Co-authored-by: Logic <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: cuipiheqiuqiu <[email protected]>
Co-authored-by: Logic <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: cuipiheqiuqiu <[email protected]>
Co-authored-by: Logic <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: cuipiheqiuqiu <[email protected]>
Co-authored-by: Logic <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] <fix and pass the checkstyle error in common module code>
4 participants