Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support monitor metrics name i18n: zookeeper #1588

Merged
merged 1 commit into from
Feb 27, 2024
Merged

support monitor metrics name i18n: zookeeper #1588

merged 1 commit into from
Feb 27, 2024

Conversation

cuipiheqiuqiu
Copy link
Contributor

support monitor metrics name i18n: zookeeper

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 27, 2024
tomsun28
tomsun28 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2024
@tomsun28 tomsun28 merged commit 0aed940 into apache:master Feb 27, 2024
1 of 2 checks passed
a-little-fool pushed a commit that referenced this pull request Feb 28, 2024
@cuipiheqiuqiu @a-little-fool
support monitor metrics name i18n: zookeeper (#1588)
e6311ce
a-little-fool pushed a commit that referenced this pull request Feb 28, 2024
@cuipiheqiuqiu @a-little-fool
support monitor metrics name i18n: zookeeper (#1588)
8cebdbd
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@cuipiheqiuqiu
support monitor metrics name i18n: zookeeper (#1588)
3bb4235
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@cuipiheqiuqiu
support monitor metrics name i18n: zookeeper (#1588)
d931e01
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@cuipiheqiuqiu @tomsun28
support monitor metrics name i18n: zookeeper (#1588)
74159d4
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@cuipiheqiuqiu
support monitor metrics name i18n: zookeeper (#1588)
78fc44c
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@cuipiheqiuqiu @tomsun28
support monitor metrics name i18n: zookeeper (#1588)
f9840bb
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@cuipiheqiuqiu
support monitor metrics name i18n: zookeeper (#1588)
191431a
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@cuipiheqiuqiu
support monitor metrics name i18n: zookeeper (#1588)
f47875f
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@cuipiheqiuqiu
support monitor metrics name i18n: zookeeper (#1588)
3fde4b1
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@cuipiheqiuqiu
support monitor metrics name i18n: zookeeper (#1588)
c70c63d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuipiheqiuqiu @tomsun28