Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] <remove the unlicense dependency wolfy87-eventemitter in frontend web-app> #1739

Closed
2 tasks
tomsun28 opened this issue Apr 13, 2024 · 3 comments · Fixed by #1745
Closed
2 tasks

[Task] <remove the unlicense dependency wolfy87-eventemitter in frontend web-app> #1739

tomsun28 opened this issue Apr 13, 2024 · 3 comments · Fixed by #1745
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed status: volunteer wanted task

Comments

@tomsun28
Copy link
Contributor

Description

The web-app dependency wolfy87-eventemitter is unlicense, we can not use it.

This task requires finding which component third parties depend on it and remove the unlicense dependency wolfy87-eventemitter in frontend web-app.

https://npmjs.com/package/wolfy87-eventemitter/v/5.2.9 5.2.9 Unlicense

Task List

@tomsun28 tomsun28 added status: volunteer wanted good first issue Good for newcomers help wanted Extra attention is needed task labels Apr 13, 2024
@alpha951
Copy link
Contributor

Could you please assign this issue to me ?

@tomsun28
Copy link
Contributor Author

@alpha951 hi welcome, has assigned to you. Btw, i think we can remove the unused package @delon/chart in web-app to solve this, due the the package depend the wolfy87-eventemitter.

@alpha951
Copy link
Contributor

Hey @tomsun28 , I've raised a PR #1745 addressing this issue. Let me know if anything is need to be updated.

@tomsun28 tomsun28 linked a pull request Apr 15, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed status: volunteer wanted task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants