Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway util for per key lock and per key blocking queue executor #2847

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented Jul 24, 2024

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Gateway util for per key lock and per key blocking queue executor

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Add per key lock and per key blocking queue executor

Tests

  • The following tests are written for this issue:
  • 2 new test class
    TestPerKeyBlockingExecutor and TestPerKeyBlockingExecutor

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu xyuanlu changed the base branch from master to helix-gateway-service July 24, 2024 17:46
@xyuanlu xyuanlu marked this pull request as ready for review July 24, 2024 18:26
@xyuanlu
Copy link
Contributor Author

xyuanlu commented Jul 24, 2024

This change is ready to be merged. Approved by @zpinto
Commit message: [Gateway util for per key lock and per key blocking queue executor]

@xyuanlu xyuanlu merged commit fc4a2e1 into apache:helix-gateway-service Jul 24, 2024
1 check passed
asfgit pushed a commit that referenced this pull request Aug 2, 2024
Gateway util for per key lock and per key blocking queue executor
asfgit pushed a commit that referenced this pull request Sep 6, 2024
Gateway util for per key lock and per key blocking queue executor
asfgit pushed a commit that referenced this pull request Sep 8, 2024
Gateway util for per key lock and per key blocking queue executor
asfgit pushed a commit that referenced this pull request Sep 18, 2024
Gateway util for per key lock and per key blocking queue executor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants