-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] A poor naming. #4521
Comments
Hey @pandaapo i want to work on it. Please assign me |
Welcome! @Asymtode712 |
Thanks @pandaapo for assigning it, before making all the changes just wanted to ask you, would 'Faults' be an appropriate replacement for 'Errors' |
@pandaapo Hi, may I ask if you've seen this reply? #4498 (comment) It has already been fixed in https://github.com/Pil0tXia/eventmesh/blob/pil0txia_feat_4501/eventmesh-admin/src/main/java/org/apache/eventmesh/admin/enums/Status.java. |
No, I don't think it is appropriate either. |
@pandaapo Since you've pointed out this issue, I agree with your perspective, and you've also seen my response, so you will definitely find the changes to this class in my next PR. Please rest assured. 😏 |
@Pil0tXia Yes, I saw this reply #4498 (comment) 9 days ago. 我在9天前看到该回复#4498 (comment) 。 |
@Pil0tXia 在你回复了 以后,你的下一个PR是#4518。 |
@pandaapo Please review my PR and suggest if there are some changes to be done. |
@Pil0tXia 我已经说了我不会专门去你的仓库中找一个分支来看你平时的修改,任何人都不会。你在你自己的分支上做的修改,除了你还有谁会知道? |
I had already provided an affirmative response before I submitted the code to my own branch. Since you've also seen that reply, if you're concerned about my development progress or whether I've forgotten about this matter, you can contact me directly below my response or mention me in a new issue, without the need to open a good first issue. Of course, a new issue is also not a problem. I explained the situation to you right away, indicating that the issue has already been resolved, and it is planned to be submitted along with another PR. You can rest assured. It's OK to leave this issue to me. 在我向我自己的分支提交代码之前,就已经给您肯定的回复了。既然您也看到了那条回复,如果您关心我的开发进度,以及我有没有忘掉这件事情,您可以直接在我的回复下面联系我,或者在新issue里 当然,一个issue也没什么,我也第一时间跟您解释清楚情况了,说明了这个问题已经被解决了,以及它随另一个PR提交的计划。您大可放心。 这个issue交给我就行,有劳了! |
@pandaapo I have made all the changes. Please review my PR |
@Pil0tXia Now I have also assigned the issue to you and explained that I will merge the better one. But it seems that you are more willing to argue than submit a PR of some relevant code first. I believe that as the author of this code, you can quickly and resolve this issue better. I am quite busy with work today, so I don't have time to participate in community affairs before I finish work. Please understand. Thank you. If I haven't seen your PR after work and Asymtode712's PR completes the issue well before your PR submission, I will approve it first. 我更多的是只关注项目本身。就该issue而言,并不是很急的需求,没想过要催促谁,也没认为必须谁来完成。经过很长时间,想起这段代码,同时也没看到任何相关issue和PR,我觉得可以提个issue。 现在我已经也将该issue分配给你,并说明会择优合并。但你似乎更愿意辩论,而不先提交一部分相关代码的PR。我相信你作为该代码的作者能很快更好地解决该issue。今天工作比较忙,下班之前我没有时间参与社区事务。请理解,谢谢。 如果下班后没有看到你的PR,同时Asymtode712的PR能很好地完成该issue,我会先review通过。 |
I will take some time to review the relevant PRs after work today. |
Search before asking
Enhancement Request
eventmesh/eventmesh-admin/src/main/java/org/apache/eventmesh/admin/enums/Errors.java
Lines 36 to 38 in 11def17
A class that defines multiple response states, including
SUCCESS
state, but the class name isErrors
. Bad smell should be avoided in our codes. Because it will reduce code's readability and maintainability, and also confuse developers.Describe the solution you'd like
Change the class name to an appropriate name.
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: