Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Refactor eventmesh-metrics-prometheus module #3430

Closed
2 tasks done
mxsm opened this issue Mar 12, 2023 · 1 comment · Fixed by #4840
Closed
2 tasks done

[Enhancement] Refactor eventmesh-metrics-prometheus module #3430

mxsm opened this issue Mar 12, 2023 · 1 comment · Fixed by #4840
Labels
enhancement New feature or request

Comments

@mxsm
Copy link
Member

mxsm commented Mar 12, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Refactor eventmesh-metrics-prometheus module.

Describe the solution you'd like

  1. The current project is using a lower version of OpenTelemetry components, version 1.3.0, while the latest version is 1.24.0. The related versions need to be upgraded.
  2. The version upgrade brings new specifications and features, requiring code refactoring.
  3. The instrumentation of metrics needs to be adjusted accordingly based on the related semantic conversion specifications of OpenTelemetry. (https://opentelemetry.io/docs/reference/specification/metrics/semantic_conventions/)
  4. Optimize and refactor the related code logic to make the code clearer.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@mxsm mxsm added the enhancement New feature or request label Mar 12, 2023
@mxsm mxsm changed the title [Enhancement] Refactor eventmesh-metrics-prometheus module [WIP][Enhancement] Refactor eventmesh-metrics-prometheus module Mar 12, 2023
@mxsm mxsm mentioned this issue Mar 13, 2023
Closed
@mxsm mxsm changed the title [WIP][Enhancement] Refactor eventmesh-metrics-prometheus module [Enhancement] Refactor eventmesh-metrics-prometheus module Mar 13, 2023
@mxsm mxsm mentioned this issue May 13, 2023
Closed
2 tasks
@mxsm
Copy link
Member Author

mxsm commented Jul 17, 2023 •
edited
Loading

chinese document about metrics. The documentation will be updated on the official website as part of the code merge and subsequent PR submission. Additionally, further optimizations will be made to improve the documentation.

mxsm added a commit to mxsm/incubator-eventmesh that referenced this issue Apr 14, 2024
@mxsm
[ISSUE apache#3430]Refactor eventmesh-metrics-prometheus module
d6bade5
mxsm added a commit to mxsm/incubator-eventmesh that referenced this issue Apr 14, 2024
@mxsm
[ISSUE apache#3430]Refactor eventmesh-metrics-prometheus module
b1f3e3a
mxsm added a commit to mxsm/incubator-eventmesh that referenced this issue Apr 14, 2024
@mxsm
[ISSUE apache#3430]Refactor eventmesh-metrics-prometheus module
ef6dd44
@mxsm mxsm mentioned this issue Apr 14, 2024
Merged
mxsm added a commit to mxsm/incubator-eventmesh that referenced this issue Apr 14, 2024
@mxsm
[ISSUE apache#3430]Refactor eventmesh-metrics-prometheus module
8936c98
xwm1992 pushed a commit that referenced this issue Apr 19, 2024
@mxsm
[ISSUE #3430] Refactor eventmesh-metrics-prometheus module (#4840)
a899e54 
* [ISSUE #3430]Refactor eventmesh-metrics-prometheus module

* optimize code

* optimize code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@mxsm