Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Method stores return result in local before immediately returning it [HttpSummaryMetrics] #2385

Closed
1 of 2 tasks
Alonexc opened this issue Dec 2, 2022 · 1 comment · Fixed by #2431
Closed
1 of 2 tasks

[Enhancement] Method stores return result in local before immediately returning it [HttpSummaryMetrics] #2385

Alonexc opened this issue Dec 2, 2022 · 1 comment · Fixed by #2431
Assignees
@keranbingaa
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Dec 2, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
located at:
eventmesh-metrics-plugin/eventmesh-metrics-api/src/main/java/org/apache/eventmesh/metrics/api/model/HttpSummaryMetrics.java line 64 69 95 100 130 164 169 229 234 326 331 390 400 410
analysis and explanation:
This method stores the return result in a local variable, and then immediately returns the local variable. It would be simpler just to return the value that is assigned to the local variable,

Describe the solution you'd like

reference:
image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Dec 2, 2022
@Alonexc Alonexc mentioned this issue Dec 2, 2022
Open
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label Dec 2, 2022
@keranbingaa
Copy link
Contributor

I want to fix it

keranbingaa added a commit to keranbingaa/incubator-eventmesh that referenced this issue Dec 3, 2022
@keranbingaa
fixed apache#2385
9766f4e
@keranbingaa keranbingaa mentioned this issue Dec 3, 2022
Merged
jonyangx pushed a commit that referenced this issue Dec 3, 2022
@keranbingaa
fixed #2385 (#2431)
01bb682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keranbingaa keranbingaa

Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #2385] return direct result rather than local variable keranbingaa/incubator-eventmesh
3 participants
@xwm1992 @keranbingaa @Alonexc