Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Duplicated type declarations in dist type files #19663

Closed
Justineo opened this issue Feb 29, 2024 · 0 comments · Fixed by #20030
Closed

[Bug] Duplicated type declarations in dist type files #19663

Justineo opened this issue Feb 29, 2024 · 0 comments · Fixed by #20030
Assignees
Labels
bug en This issue is in English

Comments

@Justineo
Copy link
Contributor

Version

5.5.0

Link to Minimal Reproduction

https://www.npmjs.com/package/echarts?activeTab=code

Steps to Reproduce

Look at types/dist/echarts.d.ts and types/dist/shared.d.ts.

Current Behavior

They are almost the same.

Expected Behavior

Shouldn't produce duplicated type declarations.

Environment

- OS:
- Browser:
- Framework:

Any additional comments?

This seems to lead to problems like ecomfe/vue-echarts#766.

@Justineo Justineo added the bug label Feb 29, 2024
@echarts-bot echarts-bot bot added en This issue is in English pending We are not sure about whether this is a bug/new feature. labels Feb 29, 2024
@100pah 100pah added this to the 5.5.1 milestone May 10, 2024
@100pah 100pah self-assigned this May 10, 2024
@Ovilia Ovilia closed this as completed in 71541f8 Jun 14, 2024
@plainheart plainheart removed this from the 5.5.1 milestone Jun 18, 2024
@plainheart plainheart removed the pending We are not sure about whether this is a bug/new feature. label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug en This issue is in English
Projects
None yet
3 participants