Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sunburst): label rotation flipping #19176

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Oct 8, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Many cases were reported with sunburst's label rotation and several PRs trying to fix them have been merged (#18240, #18962, #19174). This PR refactored and simplified the related code, fixes the problem of #19127 and tested all reported cases and make sure the label rotation algorithm is as robust as possible.

Fixed issues

Details

Before: What was the problem?

Label align is not syncing with rotation flipping, so the text is at the wrong position.

image

After: How does it behave after the fixing?

Use needsFlip to make sure this logic is the same with align and rotation.

image

Diff:

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

I've run the visual test with the last version 5.4.3 and the result is as expected. I've also tested all rotation values and clockwise values to make sure the text is always in the readable direction.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 8, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 5.5.0 milestone Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19176@d9e67dd

Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much neater!

@plainheart plainheart linked an issue Nov 1, 2023 that may be closed by this pull request
@plainheart plainheart merged commit 818853e into master Nov 1, 2023
2 checks passed
Copy link

echarts-bot bot commented Nov 1, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 旭日图新版本label位置bug
2 participants