Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbox): fix toolbox text can't apply the specified or global font style #19170

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Oct 3, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix the bug that the toolbox text neither applies the specified font style nor inherits from the global font style

Fixed issues

N.A.

Details

Before: What was the problem?

The toolbox text doesn't apply the custom fonts. Demo

After: How does it behave after the fixing?

Demo

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the second test case in test/toolbox-textStyle.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

It would be better to use label#createTextStyle to support more text style and extract the textStyle option from the current iconStyle in the future.

@echarts-bot
Copy link

echarts-bot bot commented Oct 3, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart added this to the 5.5.0 milestone Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19170@0508353

@Ovilia Ovilia merged commit 4a3d090 into master Oct 4, 2023
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Oct 4, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants