fix(sankey): fix value is undefined in label/edgeLabel formatter
#18733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
This was
linked to
issues
Jun 8, 2023
Closed
adoin
suggested changes
Jun 9, 2023
|
@adoin How did you test this branch? I can't reproduce the bad case you mentioned. You have suggested changes, do you mean it works or can't work? 
Please use the following commands to get a clean workspace: $ git clone -b fix/sankey-label-formatter https://github.com/apache/echarts --depth=1
$ cd echarts
$ npm i
$ npm run dev |
hexiaokang
approved these changes
Jun 9, 2023
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Revert changes made in 修复：Sankey桑基图Label Value总是undefined的问题。 #18222 to fix
valueis undefined in label formatter callback.See [Bug] Pie label-formatter show undefined for {c} while echarts.ts compiled to echarts.js #18729.
Correctly fix
valueis undefined in sankeylabel&edgeLabelformatter.Prevent
edgeLabel.formatterfrom inheriting serieslabel.formatter.Fixed issues
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
Please refer to
test/sankey-labelValue.htmland the second test case intest/pie-label.html.Others
Merging options
Other information