Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): fix wrong type for data item value of the parallel series. #18425

Merged
merged 1 commit into from
Mar 27, 2023
Merged

fix(type): fix wrong type for data item value of the parallel series. #18425

merged 1 commit into from
Mar 27, 2023

Conversation

manishdait
Copy link
Contributor

@manishdait manishdait commented Mar 27, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed datatype of Typescript in echarts/src/chart/parallel/ParallelSeries.ts file for
value? : ParallelSeriesDataValue[]
to
value?: ParallelSeriesDataValue

Fixed issues

#18411

Details

The issue is fixed as discuss in dscussion

Before: What was the problem?

The typescript compiler shows an error when creating a ParallelSeriesOption

After: How does it behave after the fixing?

The typescript compiler will not show error when creating a ParallelSeriesOption

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 27, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@plainheart plainheart added this to the 5.5.0 milestone Mar 27, 2023
@plainheart plainheart changed the title fix(src/chart/parall): fix datatype. close #18411 fix(type): fix wrong type for data item value of the parallel series. Mar 27, 2023
@plainheart plainheart merged commit f27b615 into apache:master Mar 27, 2023
@echarts-bot
Copy link

echarts-bot bot commented Mar 27, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Wrong TypeScript type for ParallelSeriesDataItemOption value property
2 participants